Can use () instead of [] as Notch shows in http://i.imgur.com/XIXc4.jpg#6
Open
rayslava wants to merge 13 commits intoswetland:masterfrom
rayslava:master
Open
Can use () instead of [] as Notch shows in http://i.imgur.com/XIXc4.jpg#6rayslava wants to merge 13 commits intoswetland:masterfrom rayslava:master
rayslava wants to merge 13 commits intoswetland:masterfrom
rayslava:master
Conversation
I do know that this solution is not nice but adding new class of brackets will cause too much refactoring. So [A) and (A] work too =)
Seen in Notches latest screenshot http://i.imgur.com/Tq9ue.jpg Note that colour printing in the program output does not work yet but the facility is there.
Note however terminal colour output isn't finished.
Conflicts: assembler.c emulator.c
Owner
|
At some point I'm going to have to decide if I'm going to follow all of Notch's syntactic decisions or not (personally I prefer []s to ()s and much prefer [imm, reg] to [imm + reg] though I support both). () support is pretty harmless. His use of "DAT" and "BOR" also strike me as really weird, but it's probably worth staying compatible with his syntax even if it's weird-looking to me. ^^ |
Contributor
Author
|
I think FASM syntax is the best from x86 assemblers — light and powerful. Why not to imitate it? And "BOR" is frightening me too. My mind can't decrypt such strange mnemonic in a moment so I stumble every time seeing this instruction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do know that this solution is not nice but adding new class of brackets would cause too much refactoring.
So [A) and (A] work too =)